Replace sprintf with snprintf

* A few strcpy and strcat changes as well

9 files changed, 27 insertions, 23 deletions

diff --git a/tests/test_artifactory.c b/tests/test_artifactory.c
index 202a67c..0d84289 100644
--- a/tests/test_artifactory.c
+++ b/tests/test_artifactory.c
@@ -60,7 +60,7 @@ void test_jfrog_cli_rt_download() {
 
     char *filename = "empty_file_upload.txt";
     char path[PATH_MAX] = {0};
-    sprintf(path, "%s/%s", getenv("STASIS_JF_REPO"), filename);
+    snprintf(path, sizeof(path), "%s/%s", getenv("STASIS_JF_REPO"), filename);
     STASIS_ASSERT(jfrog_cli_rt_download(&gauth, &dl, filename, ".") == 0, "jf download failed");
     STASIS_ASSERT(jfrog_cli_rt_delete(&gauth, path) == 0, "jf delete test artifact failed");
 }
@@ -93,15 +93,15 @@ int main(int argc, char *argv[]) {
     }
 
     char path[PATH_MAX] = {0};
-    sprintf(path, "%s/bin:%s", ctx.storage.tools_dir, getenv("PATH"));
+    snprintf(path, sizeof(path), "%s/bin:%s", ctx.storage.tools_dir, getenv("PATH"));
     setenv("PATH", path, 1);
 
     // The default config contains the URL information to download jfrog-cli
     char cfg_path[PATH_MAX] = {0};
     if (strstr(sysconfdir, "..")) {
-        sprintf(cfg_path, "%s/%s/stasis.ini", basedir, sysconfdir);
+        snprintf(cfg_path, sizeof(cfg_path), "%s/%s/stasis.ini", basedir, sysconfdir);
     } else {
-        sprintf(cfg_path, "%s/stasis.ini", sysconfdir);
+        snprintf(cfg_path, sizeof(cfg_path), "%s/stasis.ini", sysconfdir);
     }
     ctx._stasis_ini_fp.cfg = ini_open(cfg_path);
     if (!ctx._stasis_ini_fp.cfg) {
diff --git a/tests/test_conda.c b/tests/test_conda.c
index 1d05e7e..9f0e718 100644
--- a/tests/test_conda.c
+++ b/tests/test_conda.c
@@ -40,7 +40,7 @@ struct Delivery ctx;
 
 void test_conda_installation() {
     char *install_url = calloc(255, sizeof(install_url));
-    delivery_get_conda_installer_url(&ctx, install_url);
+    delivery_get_conda_installer_url(&ctx, install_url, PATH_MAX);
     delivery_get_conda_installer(&ctx, install_url);
     delivery_install_conda(ctx.conda.installer_path, ctx.storage.conda_install_prefix);
 
@@ -92,7 +92,7 @@ void test_conda_exec() {
 void test_python_exec() {
     const char *python_system_path = find_program("python3");
     char python_path[PATH_MAX];
-    sprintf(python_path, "%s/bin/python3", ctx.storage.conda_install_prefix);
+    snprintf(python_path, sizeof(python_path), "%s/bin/python3", ctx.storage.conda_install_prefix);
 
     STASIS_ASSERT(strcmp(python_path, python_system_path ? python_system_path : "/not/found") == 0, "conda is not configured correctly.");
     STASIS_ASSERT(python_exec("-V") == 0, "python is broken");
diff --git a/tests/test_environment.c b/tests/test_environment.c
index 4f36883..9a503c0 100644
--- a/tests/test_environment.c
+++ b/tests/test_environment.c
@@ -58,7 +58,7 @@ void test_runtime() {
 
     char output_truth[BUFSIZ] = {0};
     char *your_path = runtime_get(env, "PATH");
-    sprintf(output_truth, "Your PATH is '%s'.", your_path);
+    snprintf(output_truth, sizeof(output_truth), "Your PATH is '%s'.", your_path);
     guard_free(your_path);
 
     char *output_expanded = runtime_expand_var(env, "Your PATH is '${PATH}'.");
diff --git a/tests/test_multiprocessing.c b/tests/test_multiprocessing.c
index 3a462f1..3b98b77 100644
--- a/tests/test_multiprocessing.c
+++ b/tests/test_multiprocessing.c
@@ -65,7 +65,7 @@ void test_mp_task() {
         for (size_t i = 0; i < sizeof(commands) / sizeof(*commands); i++) {
             struct MultiProcessingTask *task;
             char task_name[100] = {0};
-            sprintf(task_name, "mytask%zu", i);
+            snprintf(task_name, sizeof(task_name), "mytask%zu", i);
             STASIS_ASSERT_FATAL((task = mp_pool_task(pool, task_name, NULL, commands[i])) != NULL, "Task should not be NULL");
             STASIS_ASSERT(task->pid == MP_POOL_PID_UNUSED, "PID should be non-zero at this point");
             STASIS_ASSERT(task->parent_pid == MP_POOL_PID_UNUSED, "Parent PID should be non-zero");
diff --git a/tests/test_recipe.c b/tests/test_recipe.c
index fc7cc78..3ea21ce 100644
--- a/tests/test_recipe.c
+++ b/tests/test_recipe.c
@@ -4,7 +4,7 @@
 
 static void make_local_recipe(const char *localdir) {
     char path[PATH_MAX] = {0};
-    sprintf(path, "./%s", localdir);
+    snprintf(path, sizeof(path), "./%s", localdir);
     mkdir(path, 0755);
     if (!pushd(path)) {
         touch("meta.yaml");
diff --git a/tests/test_system.c b/tests/test_system.c
index 2271e13..9e4a862 100644
--- a/tests/test_system.c
+++ b/tests/test_system.c
@@ -54,7 +54,7 @@ void test_shell_safe_verify_restrictions() {
         char cmd[PATH_MAX] = {0};
         memset(&proc, 0, sizeof(proc));
 
-        sprintf(cmd, "true%c false", invalid_chars[i]);
+        snprintf(cmd, sizeof(cmd), "true%c false", invalid_chars[i]);
         shell_safe(&proc, cmd);
         STASIS_ASSERT(proc.returncode == -1, "expected a negative result due to intentional error");
     }
diff --git a/tests/test_template.c b/tests/test_template.c
index 596c2b7..aaba03b 100644
--- a/tests/test_template.c
+++ b/tests/test_template.c
@@ -10,8 +10,9 @@ static int adder(struct tplfunc_frame *frame, void *result) {
     int a = (int) strtol(frame->argv[0].t_char_ptr, NULL, 10);
     int b = (int) strtol(frame->argv[1].t_char_ptr, NULL, 10);
     char **ptr = (char **) result;
-    *ptr = calloc(100, sizeof(*ptr));
-    sprintf(*ptr, "%d", a + b);
+    const size_t sz = 100;
+    *ptr = calloc(sz, sizeof(*ptr));
+    snprintf(*ptr, sz, "%d", a + b);
     return 0;
 }
 
@@ -19,8 +20,9 @@ static int subtractor(struct tplfunc_frame *frame, void *result) {
     int a = (int) strtol(frame->argv[0].t_char_ptr, NULL, 10);
     int b = (int) strtol(frame->argv[1].t_char_ptr, NULL, 10);
     char **ptr = (char **) result;
-    *ptr = calloc(100, sizeof(*ptr));
-    sprintf(*ptr, "%d", a - b);
+    const size_t sz = 100;
+    *ptr = calloc(sz, sizeof(*ptr));
+    snprintf(*ptr, sz, "%d", a - b);
     return 0;
 }
 
@@ -28,8 +30,9 @@ static int multiplier(struct tplfunc_frame *frame, void *result) {
     int a = (int) strtol(frame->argv[0].t_char_ptr, NULL, 10);
     int b = (int) strtol(frame->argv[1].t_char_ptr, NULL, 10);
     char **ptr = (char **) result;
-    *ptr = calloc(100, sizeof(*ptr));
-    sprintf(*ptr, "%d", a * b);
+    const size_t sz = 100;
+    *ptr = calloc(sz, sizeof(*ptr));
+    snprintf(*ptr, sz, "%d", a * b);
     return 0;
 }
 
@@ -37,8 +40,9 @@ static int divider(struct tplfunc_frame *frame, void *result) {
     int a = (int) strtol(frame->argv[0].t_char_ptr, NULL, 10);
     int b = (int) strtol(frame->argv[1].t_char_ptr, NULL, 10);
     char **ptr = (char **) result;
-    *ptr = calloc(100, sizeof(*ptr));
-    sprintf(*ptr, "%d", a / b);
+    size_t sz = 100;
+    *ptr = calloc(sz, sizeof(*ptr));
+    snprintf(*ptr, sz, "%d", a / b);
     return 0;
 }
 
diff --git a/tests/test_utils.c b/tests/test_utils.c
index cfe79e0..5766f6c 100644
--- a/tests/test_utils.c
+++ b/tests/test_utils.c
@@ -129,7 +129,7 @@ void test_isempty_dir() {
     STASIS_ASSERT(isempty_dir(dname) > 0, "empty directory went undetected");
 
     char path[PATH_MAX];
-    sprintf(path, "%s/file.txt", dname);
+    snprintf(path, sizeof(path), "%s/file.txt", dname);
     touch(path);
 
     STASIS_ASSERT(isempty_dir(dname) == 0, "populated directory went undetected");
@@ -193,7 +193,7 @@ void test_git_clone_and_describe() {
 
     // initialize a bare repo so we can clone it
     char init_cmd[PATH_MAX];
-    sprintf(init_cmd, "git init --bare %s", repo_git);
+    snprintf(init_cmd, sizeof(init_cmd), "git init --bare %s", repo_git);
     system(init_cmd);
 
     // clone the bare repo
@@ -366,8 +366,8 @@ void test_rmtree() {
     for (size_t i = 0; i < sizeof(tree) / sizeof(*tree); i++) {
         char path[PATH_MAX];
         char mockfile[PATH_MAX + 10];
-        sprintf(path, "%s/%s", root, tree[i]);
-        sprintf(mockfile, "%s/%zu.txt", path, i);
+        snprintf(path, sizeof(path), "%s/%s", root, tree[i]);
+        snprintf(mockfile, sizeof(mockfile), "%s/%zu.txt", path, i);
         if (mkdir(path, 0755)) {
             perror(path);
             STASIS_ASSERT(false, NULL);
diff --git a/tests/test_wheel.c b/tests/test_wheel.c
index 1eabb1b..531e4b7 100644
--- a/tests/test_wheel.c
+++ b/tests/test_wheel.c
@@ -171,7 +171,7 @@ int main(int argc, char *argv[]) {
     }
 
     char *install_url = calloc(255, sizeof(install_url));
-    delivery_get_conda_installer_url(&ctx, install_url);
+    delivery_get_conda_installer_url(&ctx, install_url, PATH_MAX);
     delivery_get_conda_installer(&ctx, install_url);
     delivery_install_conda(ctx.conda.installer_path, ctx.storage.conda_install_prefix);
     guard_free(install_url);