From be5457168833d8297f6affa16bf67d9333e8ad75 Mon Sep 17 00:00:00 2001 From: Joseph Hunkeler Date: Wed, 29 Apr 2026 13:21:11 -0400 Subject: git_describe: close pipe on error --- src/lib/core/utils.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/lib/core/utils.c b/src/lib/core/utils.c index b4fd726..269dcdc 100644 --- a/src/lib/core/utils.c +++ b/src/lib/core/utils.c @@ -385,7 +385,11 @@ char *git_describe(const char *path) { if (!pp) { return NULL; } - fgets(version, sizeof(version) - 1, pp); + if (fgets(version, sizeof(version) - 1, pp) == NULL) { + pclose(pp); + popd(); + return NULL; + } strip(version); pclose(pp); popd(); @@ -412,7 +416,11 @@ char *git_rev_parse(const char *path, char *args) { if (!pp) { return NULL; } - fgets(version, sizeof(version) - 1, pp); + if (fgets(version, sizeof(version) - 1, pp) == NULL) { + pclose(pp); + popd(); + return NULL; + } strip(version); pclose(pp); popd(); -- cgit