From 49dd77f16f2575dc8b9e8979e4692d0d449abef3 Mon Sep 17 00:00:00 2001 From: Joseph Hunkeler Date: Wed, 22 Apr 2026 11:34:39 -0400 Subject: indexer_readmes: consolidate asprintf error condition handling --- src/cli/stasis_indexer/readmes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/cli/stasis_indexer') diff --git a/src/cli/stasis_indexer/readmes.c b/src/cli/stasis_indexer/readmes.c index 91c936f..4081485 100644 --- a/src/cli/stasis_indexer/readmes.c +++ b/src/cli/stasis_indexer/readmes.c @@ -63,13 +63,13 @@ int indexer_readmes(struct Delivery **ctx, const size_t nelem) { fprintf(indexfp, " - Receipt: [STASIS input file](%s)\n", conf_name_relative); char *pattern = NULL; - asprintf(&pattern, "*%s*%s*", + if (asprintf(&pattern, "*%s*%s*", latest_deliveries[i]->info.build_number, - strstr((*ctx)->rules.release_fmt, "%p") ? latest_deliveries[i]->meta.python_compact : "" ); - if (!pattern) { + strstr((*ctx)->rules.release_fmt, "%p") ? latest_deliveries[i]->meta.python_compact : "" ) < 0) { SYSERROR("%s", "Unable to allocate bytes for pattern"); return -1; } + struct StrList *docker_images = get_docker_images(latest_deliveries[i], pattern); if (docker_images && strlist_count(docker_images) -- cgit From ddd07afa39394c7b485c8d647c5db08845fa24fe Mon Sep 17 00:00:00 2001 From: Joseph Hunkeler Date: Wed, 22 Apr 2026 11:35:13 -0400 Subject: indexer_readmes: close index file handle on error --- src/cli/stasis_indexer/readmes.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/cli/stasis_indexer') diff --git a/src/cli/stasis_indexer/readmes.c b/src/cli/stasis_indexer/readmes.c index 4081485..749b1ee 100644 --- a/src/cli/stasis_indexer/readmes.c +++ b/src/cli/stasis_indexer/readmes.c @@ -105,6 +105,7 @@ int indexer_readmes(struct Delivery **ctx, const size_t nelem) { strstr((*ctx)->rules.release_fmt, "%p") ? current->meta.python_compact : "" ); if (!pattern) { SYSERROR("%s", "Unable to allocate bytes for pattern"); + fclose(indexfp); return -1; } -- cgit