From 252b9646c1cb0538123d51ced4a733f3dcfc266b Mon Sep 17 00:00:00 2001 From: Joseph Hunkeler Date: Tue, 2 Jun 2026 17:04:13 -0400 Subject: Safe strings, finally (#145) * Add string copy and catonate replacements * safe_strncpy * safe_strncat * Replace string functions * gbo.ini: Update tweakwcs to 0.9.0 * generic.ini: Update tweakwcs to 0.9.0 --- src/lib/delivery/delivery_docker.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/lib/delivery/delivery_docker.c') diff --git a/src/lib/delivery/delivery_docker.c b/src/lib/delivery/delivery_docker.c index 79e9729..9b2e1f7 100644 --- a/src/lib/delivery/delivery_docker.c +++ b/src/lib/delivery/delivery_docker.c @@ -44,8 +44,7 @@ int delivery_docker(struct Delivery *ctx) { // Append image tags to command for (size_t i = 0; i < total_tags; i++) { char *tag_orig = strlist_item(ctx->deploy.docker.tags, i); - strncpy(tag, tag_orig, sizeof(tag) - 1); - tag[sizeof(tag) - 1] = '\0'; + safe_strncpy(tag, tag_orig, sizeof(tag)); docker_sanitize_tag(tag); snprintf(args + strlen(args), sizeof(args) - strlen(args), " -t \"%s\" ", tag); } @@ -103,8 +102,7 @@ int delivery_docker(struct Delivery *ctx) { // Test the image // All tags point back to the same image so test the first one we see // regardless of how many are defined - strncpy(tag, strlist_item(ctx->deploy.docker.tags, 0), sizeof(tag) - 1); - tag[sizeof(tag) - 1] = '\0'; + safe_strncpy(tag, strlist_item(ctx->deploy.docker.tags, 0), sizeof(tag)); docker_sanitize_tag(tag); msg(STASIS_MSG_L2, "Executing image test script for %s\n", tag); -- cgit