From 95672b2e7a6cc0c07306893d5bb0b80ee3570f7a Mon Sep 17 00:00:00 2001
From: Joseph Hunkeler <jhunkeler@users.noreply.github.com>
Date: Mon, 12 Aug 2024 15:11:17 -0400
Subject: More unit tests (and fixing bugs) (#23)

* Add test_artifactory.c to suite

* Add test_ini_getval_wrapper to ini.c

* basic ini_getval_TYPE() conversion checks

* bugfix: use strtof in INIVAL_TYPE_FLOAT case

* Include stdio.h to pull in FILE structure

* bugfix: free data at index during strlist_set operation

* Previous behavior of setting the pointer to NULL introduced a subtle memory leak

* Set strlist error when index it out of range

* Import private delivery functions required for mock context creation

* Remove static declaration

* populate_delivery_cfg()

* Add test_junitxml.c

* Fix duplicate define value for JUNIT_RESULT_STATE_ERROR
* Add static junit test data
* Copy test data to current test directory
---
 src/strlist.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src/strlist.c')

diff --git a/src/strlist.c b/src/strlist.c
index d1bb926..de76744 100644
--- a/src/strlist.c
+++ b/src/strlist.c
@@ -315,11 +315,12 @@ size_t strlist_count(struct StrList *pStrList) {
 void strlist_set(struct StrList **pStrList, size_t index, char *value) {
     char *tmp = NULL;
     if (*pStrList == NULL || index > strlist_count(*pStrList)) {
+        strlist_errno = STRLIST_E_OUT_OF_RANGE;
         return;
     }
 
     if (value == NULL) {
-        (*pStrList)->data[index] = NULL;
+        guard_free((*pStrList)->data[index]);
     } else {
         tmp = realloc((*pStrList)->data[index], (strlen(value) + 1) * sizeof(char *));
         if (!tmp) {
-- 
cgit